<p><a href="https://review.coreboot.org/c/coreboot/+/30319">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30319/2//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30319/2//COMMIT_MSG@10">Patch Set #2, Line 10:</a> <code style="font-family:monospace,monospace">set bit 15 of subsystem ID</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">interesting choice</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c">File src/drivers/generic/bayhub/bh720.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c@61">Patch Set #2, Line 61:</a> <code style="font-family:monospace,monospace">             pci_or_config16(dev, PCI_SUBSYSTEM_ID, BH720_EARLY_RESET);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Move into the `if` below so you don't have to clear it in the `else`?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c@63">Patch Set #2, Line 63:</a> <code style="font-family:monospace,monospace">                           BH720_SOFTWARE_RESET);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I guess this shortcut is fine for the given device (you now exactly that it's a 32-bit memory resource); the generic way would be find_resource().</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c@91">Patch Set #2, Line 91:</a> <code style="font-family:monospace,monospace">        .init                   = bh720_init,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is rather late in ramstage. Might still save enough time, though.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30319">change 30319</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30319"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic3878ee782c8da1a28c6d669dd7eceda7c8cf4e5 </div>
<div style="display:none"> Gerrit-Change-Number: 30319 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Simon Glass <sjg@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 20 Dec 2018 11:58:55 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>