[coreboot-gerrit] Change in ...coreboot[master]: superio/ite: Add IT8786E-I

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30335 )

Change subject: superio/ite: Add IT8786E-I
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/30335/1/src/superio/ite/common/env_ctrl.h 
File src/superio/ite/common/env_ctrl.h:

https://review.coreboot.org/#/c/30335/1/src/superio/ite/common/env_ctrl.h@88 
PS1, Line 88: #define   ITE_EC_TMPIN3_ENCHANCED_INT_MODE	(1 << 7)
'ENCHANCED' may be misspelled - perhaps 'ENHANCED'?


https://review.coreboot.org/#/c/30335/1/src/superio/ite/common/env_ctrl.h@89 
PS1, Line 89: #define   ITE_EC_TMPIN2_ENCHANCED_INT_MODE	(1 << 6)
'ENCHANCED' may be misspelled - perhaps 'ENHANCED'?


https://review.coreboot.org/#/c/30335/1/src/superio/ite/common/env_ctrl.h@92 
PS1, Line 92: #define   ITE_EC_TMPIN1_ENCHANCED_INT_MODE	(1 << 3)
'ENCHANCED' may be misspelled - perhaps 'ENHANCED'?


https://review.coreboot.org/#/c/30335/1/src/superio/ite/common/env_ctrl.c 
File src/superio/ite/common/env_ctrl.c:

https://review.coreboot.org/#/c/30335/1/src/superio/ite/common/env_ctrl.c@278 
PS1, Line 278: 	if(conf->smbus_en)
space required before the open parenthesis '('



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30335
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7317da6a72db64f95f9a790ef96ed7a5f93b3aea
Gerrit-Change-Number: 30335
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 11:50:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/9994230b/attachment.html>