<p><a href="https://review.coreboot.org/c/coreboot/+/30335">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30335/1/src/superio/ite/common/env_ctrl.h">File src/superio/ite/common/env_ctrl.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30335/1/src/superio/ite/common/env_ctrl.h@88">Patch Set #1, Line 88:</a> <code style="font-family:monospace,monospace">#define   ITE_EC_TMPIN3_ENCHANCED_INT_MODE       (1 << 7)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">'ENCHANCED' may be misspelled - perhaps 'ENHANCED'?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30335/1/src/superio/ite/common/env_ctrl.h@89">Patch Set #1, Line 89:</a> <code style="font-family:monospace,monospace">#define   ITE_EC_TMPIN2_ENCHANCED_INT_MODE       (1 << 6)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">'ENCHANCED' may be misspelled - perhaps 'ENHANCED'?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30335/1/src/superio/ite/common/env_ctrl.h@92">Patch Set #1, Line 92:</a> <code style="font-family:monospace,monospace">#define   ITE_EC_TMPIN1_ENCHANCED_INT_MODE       (1 << 3)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">'ENCHANCED' may be misspelled - perhaps 'ENHANCED'?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30335/1/src/superio/ite/common/env_ctrl.c">File src/superio/ite/common/env_ctrl.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30335/1/src/superio/ite/common/env_ctrl.c@278">Patch Set #1, Line 278:</a> <code style="font-family:monospace,monospace">    if(conf->smbus_en)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30335">change 30335</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30335"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7317da6a72db64f95f9a790ef96ed7a5f93b3aea </div>
<div style="display:none"> Gerrit-Change-Number: 30335 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Michał Żygowski <michal.zygowski@3mdeb.com> </div>
<div style="display:none"> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> </div>
<div style="display:none"> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 20 Dec 2018 11:50:49 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>