[coreboot-gerrit] Change in ...coreboot[master]: util/crossgcc: patch compiler-rt to enable build with glibc 2.28

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30317 )

Change subject: util/crossgcc: patch compiler-rt to enable build with glibc 2.28
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30317/1/util/crossgcc/patches/compiler-rt-6.0.0.src_ustat.h.patch 
File util/crossgcc/patches/compiler-rt-6.0.0.src_ustat.h.patch:

https://review.coreboot.org/#/c/30317/1/util/crossgcc/patches/compiler-rt-6.0.0.src_ustat.h.patch@32 
PS1, Line 32: -  unsigned struct_ustat_sz = sizeof(struct ustat);
> see the other part of the patch. […]
Well I would say it depends. If there is a SANITIZER_LINUX that doesn't
define ustat, it wouldn't work any more. Maybe there isn't, but the lhs
suggests there is?

(I should probably eat something, then reason about this again)



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30317
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97d3d375962b22e124583b999080305628237fd5
Gerrit-Change-Number: 30317
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Comment-Date: Wed, 19 Dec 2018 17:47:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Comment-In-Reply-To: Patrick Georgi <pgeorgi at google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/fd2bc598/attachment.html>