[coreboot-gerrit] Change in ...coreboot[master]: util/crossgcc: patch compiler-rt to enable build with glibc 2.28

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30317 )

Change subject: util/crossgcc: patch compiler-rt to enable build with glibc 2.28
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30317/1/util/crossgcc/patches/compiler-rt-6.0.0.src_ustat.h.patch 
File util/crossgcc/patches/compiler-rt-6.0.0.src_ustat.h.patch:

https://review.coreboot.org/#/c/30317/1/util/crossgcc/patches/compiler-rt-6.0.0.src_ustat.h.patch@32 
PS1, Line 32: -  unsigned struct_ustat_sz = sizeof(struct ustat);
> would it still build without this with glibc < 2.28? […]
see the other part of the patch. what it does is to specify the ustat interface on its own (as it does for android, probably because its libc never exported it).

So yes, that should still build.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30317
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97d3d375962b22e124583b999080305628237fd5
Gerrit-Change-Number: 30317
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Comment-Date: Wed, 19 Dec 2018 17:36:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/fe59e42d/attachment.html>