[coreboot-gerrit] Change in ...coreboot[master]: mb/intel/kblrvp: Add helper function to get Board Id

[PraveenX Hodagatta Pranesh (Code Review)]

PraveenX Hodagatta Pranesh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30306 )

Change subject: mb/intel/kblrvp: Add helper function to get Board Id
......................................................................


Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/30306/3/src/mainboard/intel/kblrvp/board_id.h 
File src/mainboard/intel/kblrvp/board_id.h:

https://review.coreboot.org/#/c/30306/3/src/mainboard/intel/kblrvp/board_id.h@23 
PS3, Line 23: #define BOARD_ID_KBL_RVP11	0x44
> May i know where do you get this Board ID def?
Referred from BIOS Code and verified in serial log by booting Debug BIOS image.


https://review.coreboot.org/#/c/30306/3/src/mainboard/intel/kblrvp/board_id.c 
File src/mainboard/intel/kblrvp/board_id.c:

https://review.coreboot.org/#/c/30306/3/src/mainboard/intel/kblrvp/board_id.c@34 
PS3, Line 34: /* Get Board Id */
> Since we did not validate this function, please do remove it.
Done



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie20bf0d45a3568c2c433e5b844bea86aac07c47d
Gerrit-Change-Number: 30306
Gerrit-PatchSet: 4
Gerrit-Owner: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh at intel.com>
Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo at intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 19 Dec 2018 10:59:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Boon Tiong Teo <boon.tiong.teo at intel.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/a0b3c59c/attachment.html>