<p><a href="https://review.coreboot.org/c/coreboot/+/30306">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30306/3/src/mainboard/intel/kblrvp/board_id.h">File src/mainboard/intel/kblrvp/board_id.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30306/3/src/mainboard/intel/kblrvp/board_id.h@23">Patch Set #3, Line 23:</a> <code style="font-family:monospace,monospace">#define BOARD_ID_KBL_RVP11   0x44</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">May i know where do you get this Board ID def?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Referred from BIOS Code and verified in serial log by booting Debug BIOS image.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30306/3/src/mainboard/intel/kblrvp/board_id.c">File src/mainboard/intel/kblrvp/board_id.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30306/3/src/mainboard/intel/kblrvp/board_id.c@34">Patch Set #3, Line 34:</a> <code style="font-family:monospace,monospace">/* Get Board Id */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Since we did not validate this function, please do remove it.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30306">change 30306</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30306"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie20bf0d45a3568c2c433e5b844bea86aac07c47d </div>
<div style="display:none"> Gerrit-Change-Number: 30306 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 19 Dec 2018 10:59:42 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Boon Tiong Teo <boon.tiong.teo@intel.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>