[coreboot-gerrit] Change in ...coreboot[master]: mb/google/sarien: Enable ELAN Touchpad and Disable ALPS Touchpad

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30194 )

Change subject: mb/google/sarien: Enable ELAN Touchpad and Disable ALPS Touchpad
......................................................................

mb/google/sarien: Enable ELAN Touchpad and Disable ALPS Touchpad

Enable ELAN Touchpad and Disable ALPS Touchpad

BUG=b:119628524
BRANCH=master
TEST=ELAN Touchpad can work normally.

Change-Id: I7839459a70768fa95ba4871b1915d2ea86419bbb
Signed-off-by: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/30194
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Simon Glass <sjg at chromium.org>
Reviewed-by: Simon Glass <sjg at chromium.org>
Reviewed-by: Lijian Zhao <lijian.zhao at intel.com>
---
M src/mainboard/google/sarien/variants/sarien/devicetree.cb
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Lijian Zhao: Looks good to me, approved
  Simon Glass: Looks good to me, but someone else must approve
  Simon Glass: Looks good to me, approved



diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb
index 49200ad..771bec2 100644
--- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb
+++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb
@@ -219,11 +219,11 @@
 			end
 		end # I2C #0
 		device pci 15.1 on
-			chip drivers/i2c/hid
-				register "generic.hid" = ""ACPI0C50""
-				register "generic.desc" = ""Touchpad""
-				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)"
-				register "hid_desc_reg_offset" = "0x20"
+			chip drivers/i2c/generic
+				register "hid" = ""ELAN0000""
+				register "desc" = ""ELAN Touchpad""
+				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)"
+				register "probed" = "1"
 				device i2c 2c on end
 			end
 		end # I2C #1

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7839459a70768fa95ba4871b1915d2ea86419bbb
Gerrit-Change-Number: 30194
Gerrit-PatchSet: 6
Gerrit-Owner: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
Gerrit-Reviewer: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Simon Glass <sjg at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang at compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su at compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen at compal.corp-partner.google.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/eb68494f/attachment.html>