[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Fixes to initial hatch mainboard checkin

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30296 )

Change subject: mb/google/hatch: Fixes to initial hatch mainboard checkin
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/30296/1/src/mainboard/google/hatch/Kconfig 
File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/30296/1/src/mainboard/google/hatch/Kconfig@19 
PS1, Line 19: elect GBB_FLAG_FORCE_DEV_SWITCH_ON
            : 	select GBB_FLAG_FORCE_DEV_BOOT_USB
            : 	select GBB_FLAG_FORCE_DEV_BOOT_LEGACY
            : 	select GBB_FLAG_FORCE_MANUAL_RECOVERY
            : 	select EC_GOOGLE_CHROMEEC_SWITCHES
            : 	select HAS_RECOVERY_MRC_CACHE
            : 	select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN
nit: arrange these alphabetically?


https://review.coreboot.org/#/c/30296/1/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h 
File src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h:

https://review.coreboot.org/#/c/30296/1/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h@27 
PS1, Line 27: #define GPIO_EC_IN_RW	        GPP_C22
            : 
            : #define GPIO_PCH_WP	        GPP_C20
These GPIOs will also have to be configured in gpio.c



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30296
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e311c68873f10f71314e44d3a714639a06dbee8
Gerrit-Change-Number: 30296
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-Comment-Date: Tue, 18 Dec 2018 22:48:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/3b04aceb/attachment.html>