<p><a href="https://review.coreboot.org/c/coreboot/+/30296">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30296/1/src/mainboard/google/hatch/Kconfig">File src/mainboard/google/hatch/Kconfig:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30296/1/src/mainboard/google/hatch/Kconfig@19">Patch Set #1, Line 19:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">elect GBB_FLAG_FORCE_DEV_SWITCH_ON<br>     select GBB_FLAG_FORCE_DEV_BOOT_USB<br>    select GBB_FLAG_FORCE_DEV_BOOT_LEGACY<br> select GBB_FLAG_FORCE_MANUAL_RECOVERY<br> select EC_GOOGLE_CHROMEEC_SWITCHES<br>    select HAS_RECOVERY_MRC_CACHE<br> select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">nit: arrange these alphabetically?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30296/1/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h">File src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30296/1/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h@27">Patch Set #1, Line 27:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">#define GPIO_EC_IN_RW               GPP_C22<br><br>#define GPIO_PCH_WP          GPP_C20<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">These GPIOs will also have to be configured in gpio.c</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30296">change 30296</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30296"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4e311c68873f10f71314e44d3a714639a06dbee8 </div>
<div style="display:none"> Gerrit-Change-Number: 30296 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Shelley Chen <shchen@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 18 Dec 2018 22:48:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>