[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Add EC trigger events and acpi configs

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30281 )

Change subject: mb/google/hatch: Add EC trigger events and acpi configs
......................................................................


Patch Set 7:

(6 comments)

https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h 
File src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h:

https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@19 
PS7, Line 19: include <ec/ec.h>
What is this required for?


https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@21 
PS7, Line 21: #include <variant/gpio.h>
What is this required for?


https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@23 
PS7, Line 23: 
extra blank line not required.


https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@36 
PS7, Line 36: 	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)            |\
No EC_HOST_EVENT_PD_MCU?


https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@79 
PS7, Line 79: #define SIO_EC_ENABLE_PS2K      /* Enable PS/2 Keyboard */
Do you plan to enable tablet motion control device later on? If yes, can you please file a bug for the same.


https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h 
File src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h:

https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h@28 
PS7, Line 28: special DeepSX wake pin
not true on this platform.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a86f609c269cb59e546fc7ba4ba032e5ea8341a
Gerrit-Change-Number: 30281
Gerrit-PatchSet: 7
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 18 Dec 2018 22:38:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/3475bc2b/attachment.html>