<p><a href="https://review.coreboot.org/c/coreboot/+/30281">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h">File src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@19">Patch Set #7, Line 19:</a> <code style="font-family:monospace,monospace">include <ec/ec.h></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What is this required for?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@21">Patch Set #7, Line 21:</a> <code style="font-family:monospace,monospace">#include <variant/gpio.h></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What is this required for?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@23">Patch Set #7, Line 23:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">extra blank line not required.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@36">Patch Set #7, Line 36:</a> <code style="font-family:monospace,monospace">      EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)            |\</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">No EC_HOST_EVENT_PD_MCU?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@79">Patch Set #7, Line 79:</a> <code style="font-family:monospace,monospace">#define SIO_EC_ENABLE_PS2K      /* Enable PS/2 Keyboard */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do you plan to enable tablet motion control device later on? If yes, can you please file a bug for the same.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h">File src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h@28">Patch Set #7, Line 28:</a> <code style="font-family:monospace,monospace">special DeepSX wake pin</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">not true on this platform.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30281">change 30281</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30281"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3a86f609c269cb59e546fc7ba4ba032e5ea8341a </div>
<div style="display:none"> Gerrit-Change-Number: 30281 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Shelley Chen <shchen@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 18 Dec 2018 22:38:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>