[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Add memory init setup for hatch

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30248 )

Change subject: mb/google/hatch: Add memory init setup for hatch
......................................................................


Patch Set 8:

(3 comments)

https://review.coreboot.org/#/c/30248/8//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30248/8//COMMIT_MSG@9 
PS8, Line 9: implemetation
implementation


https://review.coreboot.org/#/c/30248/8/src/mainboard/google/hatch/spd/Makefile.inc 
File src/mainboard/google/hatch/spd/Makefile.inc:

https://review.coreboot.org/#/c/30248/8/src/mainboard/google/hatch/spd/Makefile.inc@18 
PS8, Line 18: empty_ddr4	# 0b000
I am guessing this is just a place holder until the actual SPDs are added? Lets ensure that 0b000 gets used for a valid SPD and is not an empty one.

Also, this should be added by variant and not here in the spd/Makefile.inc


https://review.coreboot.org/#/c/30248/8/src/mainboard/google/hatch/variants/baseboard/memory.c 
File src/mainboard/google/hatch/variants/baseboard/memory.c:

https://review.coreboot.org/#/c/30248/8/src/mainboard/google/hatch/variants/baseboard/memory.c@52 
PS8, Line 52: gpio_t
const



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30248
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9bda08bd0b9f91ebb96b39291e15473492a6bf19
Gerrit-Change-Number: 30248
Gerrit-PatchSet: 8
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 18 Dec 2018 22:24:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/69ab7264/attachment.html>