<p><a href="https://review.coreboot.org/c/coreboot/+/30248">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30248/8//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30248/8//COMMIT_MSG@9">Patch Set #8, Line 9:</a> <code style="font-family:monospace,monospace">implemetation</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">implementation</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30248/8/src/mainboard/google/hatch/spd/Makefile.inc">File src/mainboard/google/hatch/spd/Makefile.inc:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30248/8/src/mainboard/google/hatch/spd/Makefile.inc@18">Patch Set #8, Line 18:</a> <code style="font-family:monospace,monospace">empty_ddr4   # 0b000</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I am guessing this is just a place holder until the actual SPDs are added? Lets ensure that 0b000 gets used for a valid SPD and is not an empty one.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also, this should be added by variant and not here in the spd/Makefile.inc</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30248/8/src/mainboard/google/hatch/variants/baseboard/memory.c">File src/mainboard/google/hatch/variants/baseboard/memory.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30248/8/src/mainboard/google/hatch/variants/baseboard/memory.c@52">Patch Set #8, Line 52:</a> <code style="font-family:monospace,monospace">gpio_t</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">const</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30248">change 30248</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30248"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9bda08bd0b9f91ebb96b39291e15473492a6bf19 </div>
<div style="display:none"> Gerrit-Change-Number: 30248 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Shelley Chen <shchen@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 18 Dec 2018 22:24:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>