[coreboot-gerrit] Change in ...coreboot[master]: {devices, lib, security} Add Eltan vendor code for measured and verifie...

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30218 )

Change subject: {devices,lib,security} Add Eltan vendor code for measured and verified boot.
......................................................................


Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/30218/4/src/include/program_loading.h 
File src/include/program_loading.h:

https://review.coreboot.org/#/c/30218/4/src/include/program_loading.h@6 
PS4, Line 6:  * Copyright (C) 2018 Eltan B.V.
Does this change really deserve a copyright update?  Copyright is really for significant creative work - I'd argue that adding a single declaration isn't really significant or creative.

I'm not saying that a copyright can't be added, but I question it for simple changes like this - it cheapens the copyright of companies and people who made significant contributions.

Imagine if someone fixes a comment or makes a minor change in one of the later files in this commit and adds their copyright line to it.


https://review.coreboot.org/#/c/30218/4/src/vendorcode/eltan/security/mboot/mboot.c 
File src/vendorcode/eltan/security/mboot/mboot.c:

https://review.coreboot.org/#/c/30218/4/src/vendorcode/eltan/security/mboot/mboot.c@568 
PS4, Line 568: #if
We strongly discourage "#if" when a regular "if" can be used.  The compiler can't find any errors in #if.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30218
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1d5a21d40b6a31886777e8e9fe7b28c860f1a80
Gerrit-Change-Number: 30218
Gerrit-PatchSet: 4
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Tue, 18 Dec 2018 17:01:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/4bf570b8/attachment.html>