<p><a href="https://review.coreboot.org/c/coreboot/+/30218">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/4/src/include/program_loading.h">File src/include/program_loading.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/4/src/include/program_loading.h@6">Patch Set #4, Line 6:</a> <code style="font-family:monospace,monospace"> * Copyright (C) 2018 Eltan B.V.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Does this change really deserve a copyright update?  Copyright is really for significant creative work - I'd argue that adding a single declaration isn't really significant or creative.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not saying that a copyright can't be added, but I question it for simple changes like this - it cheapens the copyright of companies and people who made significant contributions.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Imagine if someone fixes a comment or makes a minor change in one of the later files in this commit and adds their copyright line to it.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/4/src/vendorcode/eltan/security/mboot/mboot.c">File src/vendorcode/eltan/security/mboot/mboot.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/4/src/vendorcode/eltan/security/mboot/mboot.c@568">Patch Set #4, Line 568:</a> <code style="font-family:monospace,monospace">#if</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">We strongly discourage "#if" when a regular "if" can be used.  The compiler can't find any errors in #if.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30218">change 30218</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30218"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic1d5a21d40b6a31886777e8e9fe7b28c860f1a80 </div>
<div style="display:none"> Gerrit-Change-Number: 30218 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com> </div>
<div style="display:none"> Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 18 Dec 2018 17:01:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>