[coreboot-gerrit] Change in ...coreboot[master]: amd/stoneyridge: Add calls to code to reset eMMC

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30237 )

Change subject: amd/stoneyridge: Add calls to code to reset eMMC
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30237/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30237/1//COMMIT_MSG@7 
PS1, Line 7: amd/stoneyridge: Add calls to code to reset eMMC
> It's soc specific in the sense that the calls are placed in soc specific functions. Otherwise I would probably have to create a device (?) calling the drivers and place them at the appropriate place. The first code has to be after memory is available, but before PCI enumeration. That's a very narrow window that changes from one platform to the next.

IIRC, that's chip_operations.init(). On every platform. If you can't add a
chip driver to your devicetree (for some reason I don't see). You could use
mainboard_ops.init() in the worst case.

Only downside is that this is in ramstage already. But as you haven't provided
any actual numbers, it's hard to tell if it would save more time when you do
it in romstage. If it turns out that you have to do it in romstage, add a
mainboard hook to your romstage main (if there isn't a fitting one yet) and
call the eMMC driver from mainboard code.

Btw. who cares that memory is already available?

> The second one is easier... after payload is loaded, before control is passed to payload. This don't need to be platform specific.

And not needed at all in case of your eMMC driver.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30237
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic664a4d7936c441fe920e30b89c2ea4452df401b
Gerrit-Change-Number: 30237
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Simon Glass <sjg at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Tue, 18 Dec 2018 16:30:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Spiegel <richard.spiegel at silverbackltd.com>
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/ccd3b029/attachment.html>