[coreboot-gerrit] Change in ...coreboot[master]: amd/stoneyridge: Add calls to code to reset eMMC

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30237 )

Change subject: amd/stoneyridge: Add calls to code to reset eMMC
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30237/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30237/1//COMMIT_MSG@7 
PS1, Line 7: amd/stoneyridge: Add calls to code to reset eMMC
> How is this SoC specific?
It's soc specific in the sense that the calls are placed in soc specific functions. Otherwise I would probably have to create a device (?) calling the drivers and place them at the appropriate place. The first code has to be after memory is available, but before PCI enumeration. That's a very narrow window that changes from one platform to the next. The second one is easier... after payload is loaded, before control is passed to payload. This don't need to be platform specific.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30237
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic664a4d7936c441fe920e30b89c2ea4452df401b
Gerrit-Change-Number: 30237
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Simon Glass <sjg at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Mon, 17 Dec 2018 14:23:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181217/66a09ba0/attachment.html>