[coreboot-gerrit] Change in ...coreboot[master]: {devices, lib, security} Add Eltan vendor code for measured and verifie...

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30218 )

Change subject: {devices,lib,security} Add Eltan vendor code for measured and verified boot.
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

Can you rip out the TPM changes and make a CL out of it?

https://review.coreboot.org/#/c/30218/4/src/device/pci_device.c 
File src/device/pci_device.c:

https://review.coreboot.org/#/c/30218/4/src/device/pci_device.c@807 
PS4, Line 807: 	if (!verified_boot_should_run_oprom(rom))
if (IS_ENABLED(CONFIG_VENDOR_ELTAN_VERIFIED_BOOT)) {
   if (!verified_boot_should_run_oprom(rom))
      return;
}


https://review.coreboot.org/#/c/30218/4/src/include/device/pci_rom.h 
File src/include/device/pci_rom.h:

https://review.coreboot.org/#/c/30218/4/src/include/device/pci_rom.h@66 
PS4, Line 66: extern int verified_boot_should_run_oprom (struct rom_header *rom_header);
Why extern and not an include?


https://review.coreboot.org/#/c/30218/4/src/include/program_loading.h 
File src/include/program_loading.h:

https://review.coreboot.org/#/c/30218/4/src/include/program_loading.h@140 
PS4, Line 140: int prog_locate_hook(struct prog *prog);
Why not a hook in prog_ops instead?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30218
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1d5a21d40b6a31886777e8e9fe7b28c860f1a80
Gerrit-Change-Number: 30218
Gerrit-PatchSet: 4
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Tue, 18 Dec 2018 15:09:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/6ed8d19b/attachment.html>