<p style="white-space: pre-wrap; word-wrap: break-word;">Can you rip out the TPM changes and make a CL out of it?</p><p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://review.coreboot.org/c/coreboot/+/30218">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/4/src/device/pci_device.c">File src/device/pci_device.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/4/src/device/pci_device.c@807">Patch Set #4, Line 807:</a> <code style="font-family:monospace,monospace">        if (!verified_boot_should_run_oprom(rom))</code></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if (IS_ENABLED(CONFIG_VENDOR_ELTAN_VERIFIED_BOOT)) {<br>   if (!verified_boot_should_run_oprom(rom))<br>      return;<br>}</pre></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/4/src/include/device/pci_rom.h">File src/include/device/pci_rom.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/4/src/include/device/pci_rom.h@66">Patch Set #4, Line 66:</a> <code style="font-family:monospace,monospace">extern int verified_boot_should_run_oprom (struct rom_header *rom_header);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why extern and not an include?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/4/src/include/program_loading.h">File src/include/program_loading.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/4/src/include/program_loading.h@140">Patch Set #4, Line 140:</a> <code style="font-family:monospace,monospace">int prog_locate_hook(struct prog *prog);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why not a hook in prog_ops instead?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30218">change 30218</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30218"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic1d5a21d40b6a31886777e8e9fe7b28c860f1a80 </div>
<div style="display:none"> Gerrit-Change-Number: 30218 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com> </div>
<div style="display:none"> Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 18 Dec 2018 15:09:18 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>