[coreboot-gerrit] Change in ...coreboot[master]: util/util_readme: Don't recommend running this script with "sh"

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30162 )

Change subject: util/util_readme: Don't recommend running this script with "sh"
......................................................................

util/util_readme: Don't recommend running this script with "sh"

util/util_readme/util_readme.sh is specifically a bash script and
requires bash-specific features such as "[[". It doesn't work when run
with a "sh" shell that only implements POSIX features, such as dash.
Thus, tell the user to run the script directly, in which case the #!
line is used.

Change-Id: I5706ffe857c5a148e9776571a377ad8647f9a4c2
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Reviewed-on: https://review.coreboot.org/c/30162
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M util/util_readme/util_readme.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved



diff --git a/util/util_readme/util_readme.sh b/util/util_readme/util_readme.sh
index cdd94dc..af688c4 100755
--- a/util/util_readme/util_readme.sh
+++ b/util/util_readme/util_readme.sh
@@ -4,7 +4,7 @@
 # in `./util` subdirectories
 #
 # Execute from root of project.  Example:
-# `sh util/util_readme/util_readme.sh`
+# `util/util_readme/util_readme.sh`
 
 UTIL_README_DIR="$(cd "$(dirname "$0")" || exit; pwd -P)"
 UTIL_DIR=$(dirname "$UTIL_README_DIR")

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30162
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5706ffe857c5a148e9776571a377ad8647f9a4c2
Gerrit-Change-Number: 30162
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181218/896748c4/attachment.html>