[coreboot-gerrit] Change in ...coreboot[master]: src/mb/google/*/Kconfig: Consistently use $(...) for variables
Jonathan Neuschäfer (Code Review)
gerrit at coreboot.org
Tue Dec 11 16:22:34 CET 2018
Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30163
Change subject: src/mb/google/*/Kconfig: Consistently use $(...) for variables
......................................................................
src/mb/google/*/Kconfig: Consistently use $(...) for variables
Using ${...} in some places is slightly confusing.
Fixes: 395cbb4f97 ("mb/*/*/Kconfig: Use CONFIG_VARIANT_DIR for devicetree")
Change-Id: Id0856a10d92786a41d45ca697945699f6f4c1f4c
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
M src/mainboard/google/cyan/Kconfig
M src/mainboard/google/glados/Kconfig
M src/mainboard/google/kahlee/Kconfig
M src/mainboard/google/sarien/Kconfig
4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/30163/1
diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig
index 917a66e..1d9b7b7 100644
--- a/src/mainboard/google/cyan/Kconfig
+++ b/src/mainboard/google/cyan/Kconfig
@@ -73,7 +73,7 @@
config DEVICETREE
string
- default "variants/${CONFIG_VARIANT_DIR}/devicetree.cb"
+ default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
config VGA_BIOS_FILE
string
diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig
index c5a80d4..80cc0f3 100644
--- a/src/mainboard/google/glados/Kconfig
+++ b/src/mainboard/google/glados/Kconfig
@@ -60,7 +60,7 @@
config DEVICETREE
string
- default "variants/${CONFIG_VARIANT_DIR}/devicetree.cb"
+ default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
config MAX_CPUS
int
diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig
index 97d15f5..13ad0b9 100644
--- a/src/mainboard/google/kahlee/Kconfig
+++ b/src/mainboard/google/kahlee/Kconfig
@@ -72,7 +72,7 @@
config DEVICETREE
string
- default "variants/${CONFIG_VARIANT_DIR}/devicetree.cb"
+ default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
config MAINBOARD_FAMILY
string
diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig
index c9e4c0b..c0bd1d8 100644
--- a/src/mainboard/google/sarien/Kconfig
+++ b/src/mainboard/google/sarien/Kconfig
@@ -88,7 +88,7 @@
config DEVICETREE
string
- default "variants/${CONFIG_VARIANT_DIR}/devicetree.cb"
+ default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
config VBOOT
select HAS_RECOVERY_MRC_CACHE
--
To view, visit https://review.coreboot.org/c/coreboot/+/30163
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0856a10d92786a41d45ca697945699f6f4c1f4c
Gerrit-Change-Number: 30163
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181211/46312ab2/attachment-0001.html>
More information about the coreboot-gerrit
mailing list