[coreboot-gerrit] Change in ...coreboot[master]: mb/google/dragonegg: Fix “Invalid GPIO pad number” issue

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30275


Change subject: mb/google/dragonegg: Fix “Invalid GPIO pad number” issue
......................................................................

mb/google/dragonegg: Fix “Invalid GPIO pad number” issue

With commit id: 6217e9beff16d805ca833e79a2931bcdb3d02a44
its expected to have valid GPIO number (not CROS_GPIO_VIRTUAL = -1) else
intel common gpio library function gpio_get_community() will die due
to invalid gpio pad number.

Hence commented out the recovery mode GPIO for now.

Change-Id: I437dbfe80961748829b835c80fc41d45e839f237
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
---
M src/mainboard/google/dragonegg/variants/baseboard/gpio.c
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/30275/1

diff --git a/src/mainboard/google/dragonegg/variants/baseboard/gpio.c b/src/mainboard/google/dragonegg/variants/baseboard/gpio.c
index 56f6219..6229ffc 100644
--- a/src/mainboard/google/dragonegg/variants/baseboard/gpio.c
+++ b/src/mainboard/google/dragonegg/variants/baseboard/gpio.c
@@ -89,7 +89,10 @@
 }
 
 static const struct cros_gpio cros_gpios[] = {
-	CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),
+	/*
+	 * TODO: re-enable recovery mode when boards are updated:
+	 * CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),
+	 */
 	CROS_GPIO_WP_AH(39, CROS_GPIO_DEVICE_NAME),
 };
 

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30275
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I437dbfe80961748829b835c80fc41d45e839f237
Gerrit-Change-Number: 30275
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181217/da59a62f/attachment.html>