<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30275">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/dragonegg: Fix “Invalid GPIO pad number” issue<br><br>With commit id: 6217e9beff16d805ca833e79a2931bcdb3d02a44<br>its expected to have valid GPIO number (not CROS_GPIO_VIRTUAL = -1) else<br>intel common gpio library function gpio_get_community() will die due<br>to invalid gpio pad number.<br><br>Hence commented out the recovery mode GPIO for now.<br><br>Change-Id: I437dbfe80961748829b835c80fc41d45e839f237<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/mainboard/google/dragonegg/variants/baseboard/gpio.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/30275/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/dragonegg/variants/baseboard/gpio.c b/src/mainboard/google/dragonegg/variants/baseboard/gpio.c</span><br><span>index 56f6219..6229ffc 100644</span><br><span>--- a/src/mainboard/google/dragonegg/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/dragonegg/variants/baseboard/gpio.c</span><br><span>@@ -89,7 +89,10 @@</span><br><span> }</span><br><span> </span><br><span> static const struct cros_gpio cros_gpios[] = {</span><br><span style="color: hsl(0, 100%, 40%);">-     CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),</span><br><span style="color: hsl(120, 100%, 40%);">+   /*</span><br><span style="color: hsl(120, 100%, 40%);">+     * TODO: re-enable recovery mode when boards are updated:</span><br><span style="color: hsl(120, 100%, 40%);">+      * CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),</span><br><span style="color: hsl(120, 100%, 40%);">+         */</span><br><span>  CROS_GPIO_WP_AH(39, CROS_GPIO_DEVICE_NAME),</span><br><span> };</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30275">change 30275</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30275"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I437dbfe80961748829b835c80fc41d45e839f237 </div>
<div style="display:none"> Gerrit-Change-Number: 30275 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>