[coreboot-gerrit] Change in ...coreboot[master]: src/cpu/intel: Set get_ia32_fsb function common
Arthur Heymans (Code Review)
gerrit at coreboot.org
Mon Dec 17 11:31:47 CET 2018
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30103 )
Change subject: src/cpu/intel: Set get_ia32_fsb function common
......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/#/c/30103/6/src/cpu/intel/common/fsb.c
File src/cpu/intel/common/fsb.c:
https://review.coreboot.org/#/c/30103/6/src/cpu/intel/common/fsb.c@43
PS6, Line 43: default:
: printk(BIOS_WARNING,
: "Warning: No supported FSB frequency. Assuming 200MHz\n");
: return 200;
: }
I'd drop this.
https://review.coreboot.org/#/c/30103/6/src/cpu/intel/common/fsb.c@57
PS6, Line 57: default:
: printk(BIOS_WARNING,
: "Warning: No supported FSB frequency. Assuming 200MHz\n");
: return 200;
: } /* default: fallthrough */
also drop this.
https://review.coreboot.org/#/c/30103/6/src/cpu/intel/common/fsb.c@63
PS6, Line 63: return -1;
print the error message here.
https://review.coreboot.org/#/c/30103/6/src/include/cpu/intel/fsb.h
File src/include/cpu/intel/fsb.h:
https://review.coreboot.org/#/c/30103/6/src/include/cpu/intel/fsb.h@19
PS6, Line 19: * if not found, it will return 200 MHz as default.
: * On error, it will return -1
this is just weird...
--
To view, visit https://review.coreboot.org/c/coreboot/+/30103
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I232bf88de7ebba6ac5865db046ce79e9b2f3ed28
Gerrit-Change-Number: 30103
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 17 Dec 2018 10:31:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181217/9bed0633/attachment.html>
More information about the coreboot-gerrit
mailing list