<p><a href="https://review.coreboot.org/c/coreboot/+/30103">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30103/6/src/cpu/intel/common/fsb.c">File src/cpu/intel/common/fsb.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30103/6/src/cpu/intel/common/fsb.c@43">Patch Set #6, Line 43:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> default:<br>                      printk(BIOS_WARNING,<br>                  "Warning: No supported FSB frequency. Assuming 200MHz\n");<br>                  return 200;<br>           }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd drop this.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30103/6/src/cpu/intel/common/fsb.c@57">Patch Set #6, Line 57:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">     default:<br>                      printk(BIOS_WARNING,<br>                  "Warning: No supported FSB frequency. Assuming 200MHz\n");<br>                  return 200;<br>           } /* default: fallthrough */<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">also drop this.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30103/6/src/cpu/intel/common/fsb.c@63">Patch Set #6, Line 63:</a> <code style="font-family:monospace,monospace">return -1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">print the error message here.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30103/6/src/include/cpu/intel/fsb.h">File src/include/cpu/intel/fsb.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30103/6/src/include/cpu/intel/fsb.h@19">Patch Set #6, Line 19:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> * if not found, it will return 200 MHz as default.<br> * On error, it will return -1<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">this is just weird...</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30103">change 30103</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30103"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I232bf88de7ebba6ac5865db046ce79e9b2f3ed28 </div>
<div style="display:none"> Gerrit-Change-Number: 30103 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 17 Dec 2018 10:31:47 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>