[coreboot-gerrit] Change in ...coreboot[master]: smsc/sch5147: Implement ACPI handling of a few LDN

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30240 )

Change subject: smsc/sch5147: Implement ACPI handling of a few LDN
......................................................................


Patch Set 2:

(3 comments)

I only had a brief look at the patch

https://review.coreboot.org/#/c/30240/2/src/superio/smsc/sch5147/acpi/superio.asl 
File src/superio/smsc/sch5147/acpi/superio.asl:

https://review.coreboot.org/#/c/30240/2/src/superio/smsc/sch5147/acpi/superio.asl@16 
PS2, Line 16: W83627DHG
wrong chip name


https://review.coreboot.org/#/c/30240/2/src/superio/smsc/sch5147/acpi/superio.asl@88 
PS2, Line 88: IO
FixedIO should also work here


https://review.coreboot.org/#/c/30240/2/src/superio/smsc/sch5147/acpi/superio.asl@154 
PS2, Line 154: IO 
FixedIO? also for the lines below



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30240
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide30a7396b6248e2037041e177dc8514533718a4
Gerrit-Change-Number: 30240
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 16 Dec 2018 17:05:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181216/09daaff2/attachment.html>