<p style="white-space: pre-wrap; word-wrap: break-word;">I only had a brief look at the patch</p><p><a href="https://review.coreboot.org/c/coreboot/+/30240">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30240/2/src/superio/smsc/sch5147/acpi/superio.asl">File src/superio/smsc/sch5147/acpi/superio.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30240/2/src/superio/smsc/sch5147/acpi/superio.asl@16">Patch Set #2, Line 16:</a> <code style="font-family:monospace,monospace">W83627DHG</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">wrong chip name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30240/2/src/superio/smsc/sch5147/acpi/superio.asl@88">Patch Set #2, Line 88:</a> <code style="font-family:monospace,monospace">IO</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">FixedIO should also work here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30240/2/src/superio/smsc/sch5147/acpi/superio.asl@154">Patch Set #2, Line 154:</a> <code style="font-family:monospace,monospace">IO </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">FixedIO? also for the lines below</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30240">change 30240</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30240"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ide30a7396b6248e2037041e177dc8514533718a4 </div>
<div style="display:none"> Gerrit-Change-Number: 30240 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 16 Dec 2018 17:05:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>