[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/skylake: Generate DMAR tables for FSP 1.1 boards

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30230 )

Change subject: soc/intel/skylake: Generate DMAR tables for FSP 1.1 boards
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30230/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30230/1//COMMIT_MSG@10 
PS1, Line 10: which
            : leaves out Skylake Chromebooks, which use FSP 1.1.
> Would be nice to have that fixed so we can finally remove the redundant path. […]
the main issue with migrating those boards, besides the devicetree changes, is that the boards existing VBTs don't work with FSP 2.0.  I tested this on google/chell and got no display until OS driver kicked in. Swapping in the sample VBT from the FSP package works, but obv. lacks all the panel-specific info of the existing VBTs.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30230
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68837f58aac357fa3f58979fe92d8993fae58640
Gerrit-Change-Number: 30230
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 15 Dec 2018 18:20:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181215/4c744e9c/attachment.html>