[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/skylake: Generate DMAR tables for FSP 1.1 boards

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30230 )

Change subject: soc/intel/skylake: Generate DMAR tables for FSP 1.1 boards
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/30230/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30230/1//COMMIT_MSG@10 
PS1, Line 10: which
            : leaves out Skylake Chromebooks, which use FSP 1.1.
Would be nice to have that fixed so we can finally remove the redundant path. The most noteworthy step when switching to FSP2.0 are additional fields to the VR configuration in the devicetree. Everything else shouldn't hurt the hardware or be caught by the compiler. Thanks to the FSP submodule hook-up, this would also make it easier to build working images with the default configuration from master.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30230
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68837f58aac357fa3f58979fe92d8993fae58640
Gerrit-Change-Number: 30230
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 15 Dec 2018 13:07:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181215/3201d71b/attachment.html>