[coreboot-gerrit] Change in ...coreboot[master]: cpu/intel/common: separate IA32_FEATURE_CONTROL lock from set_vmx()

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30229 )

Change subject: cpu/intel/common: separate IA32_FEATURE_CONTROL lock from set_vmx()
......................................................................


Patch Set 1:

(5 comments)

Thanks for bringing me back to this :)

https://review.coreboot.org/#/c/30229/1/src/cpu/intel/common/Kconfig 
File src/cpu/intel/common/Kconfig:

https://review.coreboot.org/#/c/30229/1/src/cpu/intel/common/Kconfig@11 
PS1, Line 11:  after configuring VMX
scratch this


https://review.coreboot.org/#/c/30229/1/src/cpu/intel/common/Kconfig@12 
PS1, Line 12: 	depends on ENABLE_VMX
and this


https://review.coreboot.org/#/c/30229/1/src/cpu/intel/common/common_init.c 
File src/cpu/intel/common/common_init.c:

https://review.coreboot.org/#/c/30229/1/src/cpu/intel/common/common_init.c@24 
PS1, Line 24: void set_vmx(void)
How about renaming this one to set_feature_ctrl_vmx() and keep set_vmx() with the old behaviour:

    void set_vmx(void)
    {
            set_feature_ctrl_vmx();
            set_feature_cltr_lock();
    }

would save you all the hassle with the callers, and in cases where we have configuration and locking in separate locations, we can still call them individually.


https://review.coreboot.org/#/c/30229/1/src/cpu/intel/common/common_init.c@75 
PS1, Line 75: VMX locked. 
scratch this


https://review.coreboot.org/#/c/30229/1/src/cpu/intel/fsp_model_406dx/model_406dx_init.c 
File src/cpu/intel/fsp_model_406dx/model_406dx_init.c:

https://review.coreboot.org/#/c/30229/1/src/cpu/intel/fsp_model_406dx/model_406dx_init.c@152 
PS1, Line 152: 	set_feature_ctrl_lock();
> should be locked in finalize step of cpu_dev_ops. […]
I agree, but it has to be run on the APs too which seems a bigger change.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30229
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee772fe87306b4729ca012cef8640d3858e2cb06
Gerrit-Change-Number: 30229
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: David Guckian <david.guckian at intel.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 15 Dec 2018 12:27:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <siro at das-labor.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181215/d06ed458/attachment.html>