[coreboot-gerrit] Change in ...coreboot[master]: cpu/intel/common: separate IA32_FEATURE_CONTROL lock from set_vmx()

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30229 )

Change subject: cpu/intel/common: separate IA32_FEATURE_CONTROL lock from set_vmx()
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/30229/1/src/cpu/intel/fsp_model_406dx/model_406dx_init.c 
File src/cpu/intel/fsp_model_406dx/model_406dx_init.c:

https://review.coreboot.org/#/c/30229/1/src/cpu/intel/fsp_model_406dx/model_406dx_init.c@152 
PS1, Line 152: 	set_feature_ctrl_lock();
should be locked in finalize step of cpu_dev_ops.
same for all other platforms



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30229
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee772fe87306b4729ca012cef8640d3858e2cb06
Gerrit-Change-Number: 30229
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: David Guckian <david.guckian at intel.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 15 Dec 2018 10:46:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181215/2f4c49ce/attachment.html>