[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/skylake: Generate DMAR tables for FSP 1.1 boards

Matt DeVillier (Code Review) gerrit at coreboot.org
Sat Dec 15 00:47:29 CET 2018


Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30230


Change subject: soc/intel/skylake: Generate DMAR tables for FSP 1.1 boards
......................................................................

soc/intel/skylake: Generate DMAR tables for FSP 1.1 boards

Commit c37b0e3 [soc/intel/skylake: Generate ACPI DMAR table]
only generates DMAR tables for boards using FSP 2.0, which
leaves out Skylake Chromebooks, which use FSP 1.1.

Correct this omission by adding the same functionality for
FSP 1.1 boards.

Test: build/boot on U-series Skylake Chromebook, observe
IOMMU fully functional with intel_iommu=on kernel parameter.

Change-Id: I68837f58aac357fa3f58979fe92d8993fae58640
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/soc/intel/skylake/chip.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/30230/1

diff --git a/src/soc/intel/skylake/chip.c b/src/soc/intel/skylake/chip.c
index fb01183..07ac4e8 100644
--- a/src/soc/intel/skylake/chip.c
+++ b/src/soc/intel/skylake/chip.c
@@ -60,7 +60,8 @@
 	.set_resources    = &pci_domain_set_resources,
 	.scan_bus         = &pci_domain_scan_bus,
 #if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
-	.acpi_name        = &soc_acpi_name,
+	.write_acpi_tables	= &northbridge_write_acpi_tables,
+	.acpi_name		= &soc_acpi_name,
 #endif
 };
 

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30230
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68837f58aac357fa3f58979fe92d8993fae58640
Gerrit-Change-Number: 30230
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181214/5f7de6ca/attachment-0001.html>


More information about the coreboot-gerrit mailing list