<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30230">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Generate DMAR tables for FSP 1.1 boards<br><br>Commit c37b0e3 [soc/intel/skylake: Generate ACPI DMAR table]<br>only generates DMAR tables for boards using FSP 2.0, which<br>leaves out Skylake Chromebooks, which use FSP 1.1.<br><br>Correct this omission by adding the same functionality for<br>FSP 1.1 boards.<br><br>Test: build/boot on U-series Skylake Chromebook, observe<br>IOMMU fully functional with intel_iommu=on kernel parameter.<br><br>Change-Id: I68837f58aac357fa3f58979fe92d8993fae58640<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/soc/intel/skylake/chip.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/30230/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/chip.c b/src/soc/intel/skylake/chip.c</span><br><span>index fb01183..07ac4e8 100644</span><br><span>--- a/src/soc/intel/skylake/chip.c</span><br><span>+++ b/src/soc/intel/skylake/chip.c</span><br><span>@@ -60,7 +60,8 @@</span><br><span>        .set_resources    = &pci_domain_set_resources,</span><br><span>   .scan_bus         = &pci_domain_scan_bus,</span><br><span> #if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)</span><br><span style="color: hsl(0, 100%, 40%);">-        .acpi_name        = &soc_acpi_name,</span><br><span style="color: hsl(120, 100%, 40%);">+       .write_acpi_tables      = &northbridge_write_acpi_tables,</span><br><span style="color: hsl(120, 100%, 40%);">+ .acpi_name              = &soc_acpi_name,</span><br><span> #endif</span><br><span> };</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30230">change 30230</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30230"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I68837f58aac357fa3f58979fe92d8993fae58640 </div>
<div style="display:none"> Gerrit-Change-Number: 30230 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>