[coreboot-gerrit] Change in ...coreboot[master]: northbridge: Remove unneeded include <pc80/mc146818rtc.h>

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30195 )

Change subject: northbridge: Remove unneeded include <pc80/mc146818rtc.h>
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://review.coreboot.org/#/c/30195/2/src/northbridge/amd/amdfam10/link_control.c 
File src/northbridge/amd/amdfam10/link_control.c:

https://review.coreboot.org/#/c/30195/2/src/northbridge/amd/amdfam10/link_control.c@76 
PS2, Line 76: #if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
when this kconfig option is set, the build will probably fail


https://review.coreboot.org/#/c/30195/2/src/northbridge/amd/amdfam10/misc_control.c 
File src/northbridge/amd/amdfam10/misc_control.c:

https://review.coreboot.org/#/c/30195/2/src/northbridge/amd/amdfam10/misc_control.c@64 
PS2, Line 64: 	get_option(&gart, "gart");
the include also needed here


https://review.coreboot.org/#/c/30195/2/src/northbridge/amd/amdfam10/northbridge.c 
File src/northbridge/amd/amdfam10/northbridge.c:

https://review.coreboot.org/#/c/30195/2/src/northbridge/amd/amdfam10/northbridge.c@a743 
PS2, Line 743: 
same here



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30195
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icae59721db530572d76035975a4e90686bf4fa65
Gerrit-Change-Number: 30195
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 14 Dec 2018 17:02:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181214/fecb50d1/attachment.html>