[coreboot-gerrit] Change in ...coreboot[master]: security{tpm, verified_boot, mboot}:Add measured and verified boot.

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30218 )

Change subject: security{tpm,verified_boot,mboot}:Add measured and verified boot.
......................................................................


Patch Set 2:

(18 comments)

https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c 
File src/security/mboot/mboot.c:

https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@45 
PS2, Line 45: 				if (!is_zero_buffer(
suspect code indent for conditional statements (32, 48)


https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@52 
PS2, Line 52: 				tpmHashAlgorithmBitmap |= EFI_TCG2_BOOT_HASH_ALG_SHA256;
line over 80 characters


https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@53 
PS2, Line 53: 				if (!is_zero_buffer(Pcrs.pcrSelections[index].pcrSelect,
line over 80 characters


https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@53 
PS2, Line 53: 				if (!is_zero_buffer(Pcrs.pcrSelections[index].pcrSelect,
suspect code indent for conditional statements (32, 48)


https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@104 
PS2, Line 104: 				swab16(TpmCap.data.assignedPCR.pcrSelections[index].hash);
line over 80 characters


https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@108 
PS2, Line 108: 				TpmCap.data.assignedPCR.pcrSelections[index].sizeofSelect;
line over 80 characters


https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@110 
PS2, Line 110: 				TpmCap.data.assignedPCR.pcrSelections[index].pcrSelect,
line over 80 characters


https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@125 
PS2, Line 125:  * 				unused.
please, no space before tabs


https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@192 
PS2, Line 192: 			printk(BIOS_DEBUG, "%s: SHA256 Hash Digest:\n", __func__);
line over 80 characters


https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@193 
PS2, Line 193: 			mboot_print_buffer(digest->digest.sha256, SHA256_DIGEST_SIZE);
line over 80 characters


https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@504 
PS2, Line 504: static const uint8_t crtm_version[] = CONFIG_CRTM_VERSION_STRING\
Avoid unnecessary line continuations


https://review.coreboot.org/#/c/30218/2/src/security/tpm/tss/tcg-2.0/tss.c 
File src/security/tpm/tss/tcg-2.0/tss.c:

https://review.coreboot.org/#/c/30218/2/src/security/tpm/tss/tcg-2.0/tss.c@538 
PS2, Line 538: 		hashAlgo );
space prohibited before that close parenthesis ')'


https://review.coreboot.org/#/c/30218/2/src/security/verified_boot/vboot_check.c 
File src/security/verified_boot/vboot_check.c:

https://review.coreboot.org/#/c/30218/2/src/security/verified_boot/vboot_check.c@162 
PS2, Line 162: 		cb_sha256((const uint8_t*)start, size, digest);
"(foo*)" should be "(foo *)"


https://review.coreboot.org/#/c/30218/2/src/security/verified_boot/vboot_check.c@215 
PS2, Line 215: 		if ((type & VERIFIED_BOOT_COPY_BLOCK) && (buffer) &&
suspect code indent for conditional statements (16, 32)


https://review.coreboot.org/#/c/30218/2/src/security/verified_boot/vboot_check.c@302 
PS2, Line 302: 					process_verify_list((verify_item_t *)list[i].data.file.related_items);
line over 80 characters


https://review.coreboot.org/#/c/30218/2/src/security/verified_boot/vboot_check.c@305 
PS2, Line 305: 				verified_boot_check_cbfsfile( list[i].name,
space prohibited after that open parenthesis '('


https://review.coreboot.org/#/c/30218/2/src/security/verified_boot/vboot_check.c@425 
PS2, Line 425: 					process_verify_list((verify_item_t *)list[i].data.oprom.related_items);
line over 80 characters


https://review.coreboot.org/#/c/30218/2/src/security/verified_boot/vboot_check.c@448 
PS2, Line 448: 		void *buffer = (void*) 0x01000000;
"(foo*)" should be "(foo *)"



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30218
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1d5a21d40b6a31886777e8e9fe7b28c860f1a80
Gerrit-Change-Number: 30218
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 14 Dec 2018 13:17:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181214/b4712f55/attachment.html>