<p><a href="https://review.coreboot.org/c/coreboot/+/30218">View Change</a></p><p>18 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c">File src/security/mboot/mboot.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@45">Patch Set #2, Line 45:</a> <code style="font-family:monospace,monospace">                             if (!is_zero_buffer(</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (32, 48)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@52">Patch Set #2, Line 52:</a> <code style="font-family:monospace,monospace">                              tpmHashAlgorithmBitmap |= EFI_TCG2_BOOT_HASH_ALG_SHA256;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@53">Patch Set #2, Line 53:</a> <code style="font-family:monospace,monospace">                          if (!is_zero_buffer(Pcrs.pcrSelections[index].pcrSelect,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@53">Patch Set #2, Line 53:</a> <code style="font-family:monospace,monospace">                          if (!is_zero_buffer(Pcrs.pcrSelections[index].pcrSelect,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (32, 48)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@104">Patch Set #2, Line 104:</a> <code style="font-family:monospace,monospace">                                swab16(TpmCap.data.assignedPCR.pcrSelections[index].hash);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@108">Patch Set #2, Line 108:</a> <code style="font-family:monospace,monospace">                              TpmCap.data.assignedPCR.pcrSelections[index].sizeofSelect;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@110">Patch Set #2, Line 110:</a> <code style="font-family:monospace,monospace">                              TpmCap.data.assignedPCR.pcrSelections[index].pcrSelect,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@125">Patch Set #2, Line 125:</a> <code style="font-family:monospace,monospace"> *                               unused.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@192">Patch Set #2, Line 192:</a> <code style="font-family:monospace,monospace">                    printk(BIOS_DEBUG, "%s: SHA256 Hash Digest:\n", __func__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@193">Patch Set #2, Line 193:</a> <code style="font-family:monospace,monospace">                    mboot_print_buffer(digest->digest.sha256, SHA256_DIGEST_SIZE);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/mboot/mboot.c@504">Patch Set #2, Line 504:</a> <code style="font-family:monospace,monospace">static const uint8_t crtm_version[] = CONFIG_CRTM_VERSION_STRING\</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Avoid unnecessary line continuations</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/2/src/security/tpm/tss/tcg-2.0/tss.c">File src/security/tpm/tss/tcg-2.0/tss.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/tpm/tss/tcg-2.0/tss.c@538">Patch Set #2, Line 538:</a> <code style="font-family:monospace,monospace">            hashAlgo );</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/2/src/security/verified_boot/vboot_check.c">File src/security/verified_boot/vboot_check.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/verified_boot/vboot_check.c@162">Patch Set #2, Line 162:</a> <code style="font-family:monospace,monospace">           cb_sha256((const uint8_t*)start, size, digest);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"(foo*)" should be "(foo *)"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/verified_boot/vboot_check.c@215">Patch Set #2, Line 215:</a> <code style="font-family:monospace,monospace">          if ((type & VERIFIED_BOOT_COPY_BLOCK) && (buffer) &&</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (16, 32)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/verified_boot/vboot_check.c@302">Patch Set #2, Line 302:</a> <code style="font-family:monospace,monospace">                                  process_verify_list((verify_item_t *)list[i].data.file.related_items);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/verified_boot/vboot_check.c@305">Patch Set #2, Line 305:</a> <code style="font-family:monospace,monospace">                            verified_boot_check_cbfsfile( list[i].name,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited after that open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/verified_boot/vboot_check.c@425">Patch Set #2, Line 425:</a> <code style="font-family:monospace,monospace">                                      process_verify_list((verify_item_t *)list[i].data.oprom.related_items);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/2/src/security/verified_boot/vboot_check.c@448">Patch Set #2, Line 448:</a> <code style="font-family:monospace,monospace">           void *buffer = (void*) 0x01000000;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"(foo*)" should be "(foo *)"</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30218">change 30218</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30218"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic1d5a21d40b6a31886777e8e9fe7b28c860f1a80 </div>
<div style="display:none"> Gerrit-Change-Number: 30218 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com> </div>
<div style="display:none"> Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 14 Dec 2018 13:17:37 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>