[coreboot-gerrit] Change in ...coreboot[master]: mainboard/google/poppy/variants/rammus: Fixed touchscreen function fa...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30180 )

Change subject: mainboard/google/poppy/variants/rammus: Fixed touchscreen function failed on EVT FATP
......................................................................


Patch Set 4:

(6 comments)

> Patch Set 4:
> 
> > Patch Set 4:
> > 
> > (1 comment)
> 
> GPP_E3 is for touchscreen I2C CLK & SDA enable/disable in touchscreen power on sequence . Should we define it to be touchscreen enable pin or touchscreen I2C CLK & SDA enable/disable pin ?

Code looks fine. Please update the comments as indicated.

https://review.coreboot.org/#/c/30180/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30180/4//COMMIT_MSG@7 
PS4, Line 7: Fixed touchscreen function failed on EVT FATP
Add touchscreen stop gpio control


https://review.coreboot.org/#/c/30180/4//COMMIT_MSG@12 
PS4, Line 12: ,
space after ,. No space required before ,


https://review.coreboot.org/#/c/30180/4//COMMIT_MSG@12 
PS4, Line 12:  
space not required.


https://review.coreboot.org/#/c/30180/4//COMMIT_MSG@13 
PS4, Line 13:  
space not required.


https://review.coreboot.org/#/c/30180/4/src/mainboard/google/poppy/variants/rammus/devicetree.cb 
File src/mainboard/google/poppy/variants/rammus/devicetree.cb:

https://review.coreboot.org/#/c/30180/4/src/mainboard/google/poppy/variants/rammus/devicetree.cb@267 
PS4, Line 267: 105
Is this change in delay intentional? Can you please add that to commit message?


https://review.coreboot.org/#/c/30180/4/src/mainboard/google/poppy/variants/rammus/gpio.c 
File src/mainboard/google/poppy/variants/rammus/gpio.c:

https://review.coreboot.org/#/c/30180/4/src/mainboard/google/poppy/variants/rammus/gpio.c@218 
PS4, Line 218: touchscreen_enable
> This is touchscreen operation enable, right?
Can you please update this comment to indicate this is touchscreen i2c operation enable/disable.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30180
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86452c1445243c499aeaf931dba286db169c5628
Gerrit-Change-Number: 30180
Gerrit-PatchSet: 4
Gerrit-Owner: Kane Chen <kane_chen at pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Kane Chen <kane_chen at pegatron.corp-partner.google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Jerry Chou <jerry_chou at pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu at pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 14 Dec 2018 02:25:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan at google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181214/04d44b24/attachment.html>