<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 4:</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 4:</p><p style="white-space: pre-wrap; word-wrap: break-word;">(1 comment)</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">GPP_E3 is for touchscreen I2C CLK & SDA enable/disable in touchscreen power on sequence . Should we define it to be touchscreen enable pin or touchscreen I2C CLK & SDA enable/disable pin ?</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Code looks fine. Please update the comments as indicated.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30180">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30180/4//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30180/4//COMMIT_MSG@7">Patch Set #4, Line 7:</a> <code style="font-family:monospace,monospace">Fixed touchscreen function failed on EVT FATP</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add touchscreen stop gpio control</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30180/4//COMMIT_MSG@12">Patch Set #4, Line 12:</a> <code style="font-family:monospace,monospace">,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space after ,. No space required before ,</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30180/4//COMMIT_MSG@12">Patch Set #4, Line 12:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space not required.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30180/4//COMMIT_MSG@13">Patch Set #4, Line 13:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space not required.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30180/4/src/mainboard/google/poppy/variants/rammus/devicetree.cb">File src/mainboard/google/poppy/variants/rammus/devicetree.cb:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30180/4/src/mainboard/google/poppy/variants/rammus/devicetree.cb@267">Patch Set #4, Line 267:</a> <code style="font-family:monospace,monospace">105</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is this change in delay intentional? Can you please add that to commit message?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30180/4/src/mainboard/google/poppy/variants/rammus/gpio.c">File src/mainboard/google/poppy/variants/rammus/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30180/4/src/mainboard/google/poppy/variants/rammus/gpio.c@218">Patch Set #4, Line 218:</a> <code style="font-family:monospace,monospace">touchscreen_enable</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This is touchscreen operation enable, right?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can you please update this comment to indicate this is touchscreen i2c operation enable/disable.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30180">change 30180</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30180"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I86452c1445243c499aeaf931dba286db169c5628 </div>
<div style="display:none"> Gerrit-Change-Number: 30180 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Kane Chen <kane_chen@pegatron.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kane Chen <kane_chen@pegatron.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Zhuohao Lee <zhuohao@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Jerry Chou <jerry_chou@pegatron.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-CC: Ken Lu <ken_lu@pegatron.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 14 Dec 2018 02:25:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>