[coreboot-gerrit] Change in ...coreboot[master]: Work in progress: Early eMMC phase 1 - programming bridge

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30213 )

Change subject: Work in progress: Early eMMC phase 1 - programming bridge
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/30213/1/src/drivers/generic/temp_pcie_bridge/bridge_ram.c 
File src/drivers/generic/temp_pcie_bridge/bridge_ram.c:

https://review.coreboot.org/#/c/30213/1/src/drivers/generic/temp_pcie_bridge/bridge_ram.c@30 
PS1, Line 30: int get_bases(DEVTREE_CONST struct device * bridge,
"foo * bar" should be "foo *bar"


https://review.coreboot.org/#/c/30213/1/src/drivers/generic/temp_pcie_bridge/bridge_rom.c 
File src/drivers/generic/temp_pcie_bridge/bridge_rom.c:

https://review.coreboot.org/#/c/30213/1/src/drivers/generic/temp_pcie_bridge/bridge_rom.c@46 
PS1, Line 46: 	pci_write_config32(dev, TEMP_BASE(number),value);
space required after that ',' (ctx:VxV)


https://review.coreboot.org/#/c/30213/1/src/include/device/temp_bridge.h 
File src/include/device/temp_bridge.h:

https://review.coreboot.org/#/c/30213/1/src/include/device/temp_bridge.h@51 
PS1, Line 51: int get_bases(DEVTREE_CONST struct device * bridge,
"foo * bar" should be "foo *bar"



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30213
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6d27af6e6889271f7185c73538ebda36a10e634
Gerrit-Change-Number: 30213
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 13 Dec 2018 21:09:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181213/d754bf47/attachment.html>