<p><a href="https://review.coreboot.org/c/coreboot/+/30213">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30213/1/src/drivers/generic/temp_pcie_bridge/bridge_ram.c">File src/drivers/generic/temp_pcie_bridge/bridge_ram.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30213/1/src/drivers/generic/temp_pcie_bridge/bridge_ram.c@30">Patch Set #1, Line 30:</a> <code style="font-family:monospace,monospace">int get_bases(DEVTREE_CONST struct device * bridge,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo * bar" should be "foo *bar"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30213/1/src/drivers/generic/temp_pcie_bridge/bridge_rom.c">File src/drivers/generic/temp_pcie_bridge/bridge_rom.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30213/1/src/drivers/generic/temp_pcie_bridge/bridge_rom.c@46">Patch Set #1, Line 46:</a> <code style="font-family:monospace,monospace"> pci_write_config32(dev, TEMP_BASE(number),value);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30213/1/src/include/device/temp_bridge.h">File src/include/device/temp_bridge.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30213/1/src/include/device/temp_bridge.h@51">Patch Set #1, Line 51:</a> <code style="font-family:monospace,monospace">int get_bases(DEVTREE_CONST struct device * bridge,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo * bar" should be "foo *bar"</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30213">change 30213</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30213"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib6d27af6e6889271f7185c73538ebda36a10e634 </div>
<div style="display:none"> Gerrit-Change-Number: 30213 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 13 Dec 2018 21:09:18 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>