[coreboot-gerrit] Change in ...coreboot[master]: [WIP]mb/google/sarien: Enable DMI/SATA power Optimize

Roy Mingi Park (Code Review) gerrit at coreboot.org
Thu Dec 13 18:56:22 CET 2018


Roy Mingi Park has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30212 )

Change subject: [WIP]mb/google/sarien: Enable DMI/SATA power Optimize
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://review.coreboot.org/#/c/30212/1/src/mainboard/google/sarien/variants/arcada/devicetree.cb.orig 
File src/mainboard/google/sarien/variants/arcada/devicetree.cb.orig:

https://review.coreboot.org/#/c/30212/1/src/mainboard/google/sarien/variants/arcada/devicetree.cb.orig@20 
PS1, Line 20: <<<<<<< HEAD
            : 	register "SataMode" = "0"
            : =======
            : 	register "SataMode" = "Sata_AHCI"
            : 	register "SataPortsEnable[0]" = "0"
            : 	register "SataPortsEnable[1]" = "1"
            : >>>>>>> aef7204a3f... mb/google/sarien: Use meaningful Satamode
I think this file shouldn't be uploaded.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30212
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41da2b4106d683945cdc296e2a77311176144f43
Gerrit-Change-Number: 30212
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Roy Mingi Park <roy.mingi.park at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 13 Dec 2018 17:56:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181213/d4e1918d/attachment.html>


More information about the coreboot-gerrit mailing list