[coreboot-gerrit] Change in ...coreboot[master]: mainboard/lenovo/t410s: Add new port

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/7975 )

Change subject: mainboard/lenovo/t410s: Add new port
......................................................................


Patch Set 14:

(10 comments)

https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/romstage.c 
File src/mainboard/lenovo/t410s/romstage.c:

https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/romstage.c@64 
PS14, Line 64: 			  (pci_read_config8(PCH_LPC_DEV, GEN_PMCON_3) & ~2) | 1);
line over 80 characters


https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/romstage.c@140 
PS14, Line 140: 	unsigned i;
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/romstage.c@250 
PS14, Line 250: 				  pci_read_config8(PCH_LPC_DEV, GEN_PMCON_3) | 2);
line over 80 characters


https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c 
File src/mainboard/lenovo/t410s/smihandler.c:

https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c@51 
PS14, Line 51: 	switch (smif) {
switch and case should be at the same indent


https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c@54 
PS14, Line 54: 			udelay(250000);
long udelay - prefer mdelay; see arch/arm/include/asm/delay.h


https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c@80 
PS14, Line 80: 	if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0)
do not use assignment in if condition


https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c@88 
PS14, Line 88: 	if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10)
do not use assignment in if condition


https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c@104 
PS14, Line 104: 	switch (event) {
switch and case should be at the same indent


https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c@141 
PS14, Line 141: 	switch (data) {
switch and case should be at the same indent


https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c@165 
PS14, Line 165: 			/* we have to use port 0x62/0x66, as 0x1600/0x1604 doesn't
line over 80 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/7975
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iacee1e8c217ac621b0a2b51be280b7237a6e7c2a
Gerrit-Change-Number: 7975
Gerrit-PatchSet: 14
Gerrit-Owner: Nicolas Reinecke <nr at das-labor.org>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan at koparo.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nicolas Reinecke <nr at das-labor.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Stefan T <stefan.tauner at gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 13 Dec 2018 14:15:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181213/adf49d6f/attachment.html>