<p><a href="https://review.coreboot.org/c/coreboot/+/7975">View Change</a></p><p>10 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/romstage.c">File src/mainboard/lenovo/t410s/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/romstage.c@64">Patch Set #14, Line 64:</a> <code style="font-family:monospace,monospace">                      (pci_read_config8(PCH_LPC_DEV, GEN_PMCON_3) & ~2) | 1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/romstage.c@140">Patch Set #14, Line 140:</a> <code style="font-family:monospace,monospace">       unsigned i;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/romstage.c@250">Patch Set #14, Line 250:</a> <code style="font-family:monospace,monospace">                           pci_read_config8(PCH_LPC_DEV, GEN_PMCON_3) | 2);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c">File src/mainboard/lenovo/t410s/smihandler.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c@51">Patch Set #14, Line 51:</a> <code style="font-family:monospace,monospace">   switch (smif) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">switch and case should be at the same indent</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c@54">Patch Set #14, Line 54:</a> <code style="font-family:monospace,monospace">                        udelay(250000);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">long udelay - prefer mdelay; see arch/arm/include/asm/delay.h</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c@80">Patch Set #14, Line 80:</a> <code style="font-family:monospace,monospace">       if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c@88">Patch Set #14, Line 88:</a> <code style="font-family:monospace,monospace">     if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c@104">Patch Set #14, Line 104:</a> <code style="font-family:monospace,monospace">   switch (event) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">switch and case should be at the same indent</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c@141">Patch Set #14, Line 141:</a> <code style="font-family:monospace,monospace">     switch (data) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">switch and case should be at the same indent</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/7975/14/src/mainboard/lenovo/t410s/smihandler.c@165">Patch Set #14, Line 165:</a> <code style="font-family:monospace,monospace">                      /* we have to use port 0x62/0x66, as 0x1600/0x1604 doesn't</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/7975">change 7975</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/7975"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iacee1e8c217ac621b0a2b51be280b7237a6e7c2a </div>
<div style="display:none"> Gerrit-Change-Number: 7975 </div>
<div style="display:none"> Gerrit-PatchSet: 14 </div>
<div style="display:none"> Gerrit-Owner: Nicolas Reinecke <nr@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan@koparo.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nicolas Reinecke <nr@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan T <stefan.tauner@gmx.at> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 13 Dec 2018 14:15:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>