[coreboot-gerrit] Change in ...coreboot[master]: IntelFB: Add support for Intel font driver

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30182 )

Change subject: IntelFB: Add support for Intel font driver
......................................................................


Patch Set 2:

(13 comments)

https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.h 
File src/drivers/intel/fb/fbdriver.h:

https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.h@8 
PS2, Line 8: 	FB_POS_CENTER=0,
spaces required around that '=' (ctx:VxV)


https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.h@12 
PS2, Line 12: }FB_POS;
space required after that close brace '}'


https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c 
File src/drivers/intel/fb/fbdriver.c:

https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@51 
PS2, Line 51: }
void function return statements are not generally useful


https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@55 
PS2, Line 55: 	u32 bytes = fb_info.x_resolution * fb_info.y_resolution * \
Avoid unnecessary line continuations


https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@73 
PS2, Line 73: 	if(status != 0) {
space required before the open parenthesis '('


https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@103 
PS2, Line 103: 			dst32 = (u32 *)(dst + (x * (fb_info.bits_per_pixel >> 3)));
line over 80 characters


https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@105 
PS2, Line 105: 				*dst32 = font_glyph_filled(ch, x, y) ? 0: 0xffffffff;
line over 80 characters


https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@105 
PS2, Line 105: 				*dst32 = font_glyph_filled(ch, x, y) ? 0: 0xffffffff;
spaces required around that ':' (ctx:VxW)


https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@107 
PS2, Line 107: 				*dst32 = font_glyph_filled(ch, x, y) ? 0xffffffff : 0;
line over 80 characters


https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@127 
PS2, Line 127: 	switch(position){
space required before the open brace '{'


https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@127 
PS2, Line 127: 	switch(position){
space required before the open parenthesis '('


https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@137 
PS2, Line 137: 		int_row = (4 *(vres / 5)) - (4 * FONT_SCALE);
need consistent spacing around '*' (ctx:WxV)


https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@148 
PS2, Line 148: 	for(index = 0; index < len; index++) {
space required before the open parenthesis '('



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30182
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70715d9c84dae2d0efa1631649ce27ea3c39e237
Gerrit-Change-Number: 30182
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Thu, 13 Dec 2018 09:59:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181213/662499ed/attachment.html>