<p><a href="https://review.coreboot.org/c/coreboot/+/30182">View Change</a></p><p>13 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.h">File src/drivers/intel/fb/fbdriver.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.h@8">Patch Set #2, Line 8:</a> <code style="font-family:monospace,monospace">        FB_POS_CENTER=0,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '=' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.h@12">Patch Set #2, Line 12:</a> <code style="font-family:monospace,monospace">}FB_POS;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c">File src/drivers/intel/fb/fbdriver.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@51">Patch Set #2, Line 51:</a> <code style="font-family:monospace,monospace">}</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">void function return statements are not generally useful</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@55">Patch Set #2, Line 55:</a> <code style="font-family:monospace,monospace">  u32 bytes = fb_info.x_resolution * fb_info.y_resolution * \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Avoid unnecessary line continuations</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@73">Patch Set #2, Line 73:</a> <code style="font-family:monospace,monospace">     if(status != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@103">Patch Set #2, Line 103:</a> <code style="font-family:monospace,monospace">                   dst32 = (u32 *)(dst + (x * (fb_info.bits_per_pixel >> 3)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@105">Patch Set #2, Line 105:</a> <code style="font-family:monospace,monospace">                          *dst32 = font_glyph_filled(ch, x, y) ? 0: 0xffffffff;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@105">Patch Set #2, Line 105:</a> <code style="font-family:monospace,monospace">                              *dst32 = font_glyph_filled(ch, x, y) ? 0: 0xffffffff;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that ':' (ctx:VxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@107">Patch Set #2, Line 107:</a> <code style="font-family:monospace,monospace">                            *dst32 = font_glyph_filled(ch, x, y) ? 0xffffffff : 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@127">Patch Set #2, Line 127:</a> <code style="font-family:monospace,monospace">     switch(position){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open brace '{'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@127">Patch Set #2, Line 127:</a> <code style="font-family:monospace,monospace"> switch(position){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@137">Patch Set #2, Line 137:</a> <code style="font-family:monospace,monospace">           int_row = (4 *(vres / 5)) - (4 * FONT_SCALE);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">need consistent spacing around '*' (ctx:WxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/2/src/drivers/intel/fb/fbdriver.c@148">Patch Set #2, Line 148:</a> <code style="font-family:monospace,monospace"> for(index = 0; index < len; index++) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30182">change 30182</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30182"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I70715d9c84dae2d0efa1631649ce27ea3c39e237 </div>
<div style="display:none"> Gerrit-Change-Number: 30182 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 13 Dec 2018 09:59:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>