[coreboot-gerrit] Change in ...coreboot[master]: sb/amd/pi/hudson: Fix UART address math

Marshall Dawson (Code Review) gerrit at coreboot.org
Thu Dec 6 01:41:50 CET 2018


Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30072


Change subject: sb/amd/pi/hudson: Fix UART address math
......................................................................

sb/amd/pi/hudson: Fix UART address math

Correct a build error that occurs when HUDSON_UART is selected.
Replace sizeof() of a nonexistent variable with the intended type.
This was introduced in
   bd48b23 "southbridge//hudson: Get rid of void pointer math".

BUG=b:118484178
TEST=Build Bettong with Chipset/"UART controller for Kern"

Change-Id: Icc0ff9d80c3f5cab9ab837cf1cd0cd8eb0753284
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/southbridge/amd/pi/hudson/early_setup.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/30072/1

diff --git a/src/southbridge/amd/pi/hudson/early_setup.c b/src/southbridge/amd/pi/hudson/early_setup.c
index 07c4519..3b91f9b 100644
--- a/src/southbridge/amd/pi/hudson/early_setup.c
+++ b/src/southbridge/amd/pi/hudson/early_setup.c
@@ -36,10 +36,10 @@
 	u8 byte;
 
 	byte = read8((void *)(ACPI_MMIO_BASE + AOAC_BASE + FCH_AOAC_REG56 +
-				CONFIG_UART_FOR_CONSOLE * sizeof(word)));
+				CONFIG_UART_FOR_CONSOLE * sizeof(u16)));
 	byte |= 1 << 3;
 	write8((void *)(ACPI_MMIO_BASE + AOAC_BASE + FCH_AOAC_REG56 +
-			CONFIG_UART_FOR_CONSOLE * sizeof(word)), byte);
+			CONFIG_UART_FOR_CONSOLE * sizeof(u16)), byte);
 	byte = read8((void *)(ACPI_MMIO_BASE + AOAC_BASE + FCH_AOAC_REG62));
 	byte |= 1 << 3;
 	write8((void *)(ACPI_MMIO_BASE + AOAC_BASE + FCH_AOAC_REG62), byte);

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30072
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc0ff9d80c3f5cab9ab837cf1cd0cd8eb0753284
Gerrit-Change-Number: 30072
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181206/3a2e1369/attachment-0001.html>


More information about the coreboot-gerrit mailing list