<p>Marshall Dawson has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30072">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sb/amd/pi/hudson: Fix UART address math<br><br>Correct a build error that occurs when HUDSON_UART is selected.<br>Replace sizeof() of a nonexistent variable with the intended type.<br>This was introduced in<br>   bd48b23 "southbridge//hudson: Get rid of void pointer math".<br><br>BUG=b:118484178<br>TEST=Build Bettong with Chipset/"UART controller for Kern"<br><br>Change-Id: Icc0ff9d80c3f5cab9ab837cf1cd0cd8eb0753284<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>---<br>M src/southbridge/amd/pi/hudson/early_setup.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/30072/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/southbridge/amd/pi/hudson/early_setup.c b/src/southbridge/amd/pi/hudson/early_setup.c</span><br><span>index 07c4519..3b91f9b 100644</span><br><span>--- a/src/southbridge/amd/pi/hudson/early_setup.c</span><br><span>+++ b/src/southbridge/amd/pi/hudson/early_setup.c</span><br><span>@@ -36,10 +36,10 @@</span><br><span>      u8 byte;</span><br><span> </span><br><span>         byte = read8((void *)(ACPI_MMIO_BASE + AOAC_BASE + FCH_AOAC_REG56 +</span><br><span style="color: hsl(0, 100%, 40%);">-                             CONFIG_UART_FOR_CONSOLE * sizeof(word)));</span><br><span style="color: hsl(120, 100%, 40%);">+                             CONFIG_UART_FOR_CONSOLE * sizeof(u16)));</span><br><span>     byte |= 1 << 3;</span><br><span>        write8((void *)(ACPI_MMIO_BASE + AOAC_BASE + FCH_AOAC_REG56 +</span><br><span style="color: hsl(0, 100%, 40%);">-                   CONFIG_UART_FOR_CONSOLE * sizeof(word)), byte);</span><br><span style="color: hsl(120, 100%, 40%);">+                       CONFIG_UART_FOR_CONSOLE * sizeof(u16)), byte);</span><br><span>       byte = read8((void *)(ACPI_MMIO_BASE + AOAC_BASE + FCH_AOAC_REG62));</span><br><span>         byte |= 1 << 3;</span><br><span>        write8((void *)(ACPI_MMIO_BASE + AOAC_BASE + FCH_AOAC_REG62), byte);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30072">change 30072</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30072"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icc0ff9d80c3f5cab9ab837cf1cd0cd8eb0753284 </div>
<div style="display:none"> Gerrit-Change-Number: 30072 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>