[coreboot-gerrit] Change in ...coreboot[master]: mainboard/lenovo/t430s: Add ThinkPad T431s as a variant

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30021 )

Change subject: mainboard/lenovo/t430s: Add ThinkPad T431s as a variant
......................................................................


Patch Set 8:

(4 comments)

Do you want to add a data.vbt file ?

https://review.coreboot.org/#/c/30021/8//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30021/8//COMMIT_MSG@38 
PS8, Line 38: - Detecting the model of Soldered RAM at runtime, and loading the
That should be mentioned in the Documentation !


https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/hda_verb.c 
File src/mainboard/lenovo/t430s/hda_verb.c:

https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/hda_verb.c@a16 
PS8, Line 16: 
no need to keep the empty file


https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/t431s/romstage.c 
File src/mainboard/lenovo/t430s/variants/t431s/romstage.c:

https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/t431s/romstage.c@37 
PS8, Line 37: 	pci_write_config32(PCH_LPC_DEV, LPC_GEN4_DEC, 0x0c06a1);
seems to be same as on t430, why duplicate it ?


https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/t431s/smihandler.c 
File src/mainboard/lenovo/t430s/variants/t431s/smihandler.c:

https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/t431s/smihandler.c@25 
PS8, Line 25: 	/* Enable 0x1600/0x1600 register pair */
the whole file should be removed.
The bit can be set by ec/lenovo/h8/h8.c using devicetree values.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8062cacf5e8232405bb5757e1b1d063541f354a
Gerrit-Change-Number: 30021
Gerrit-PatchSet: 8
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Comment-Date: Tue, 04 Dec 2018 08:56:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181204/ef67e8ee/attachment.html>