<p style="white-space: pre-wrap; word-wrap: break-word;">Do you want to add a data.vbt file ?</p><p><a href="https://review.coreboot.org/c/coreboot/+/30021">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30021/8//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30021/8//COMMIT_MSG@38">Patch Set #8, Line 38:</a> <code style="font-family:monospace,monospace">- Detecting the model of Soldered RAM at runtime, and loading the</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">That should be mentioned in the Documentation !</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/hda_verb.c">File src/mainboard/lenovo/t430s/hda_verb.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/hda_verb.c@a16">Patch Set #8, Line 16:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">no need to keep the empty file</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/t431s/romstage.c">File src/mainboard/lenovo/t430s/variants/t431s/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/t431s/romstage.c@37">Patch Set #8, Line 37:</a> <code style="font-family:monospace,monospace">        pci_write_config32(PCH_LPC_DEV, LPC_GEN4_DEC, 0x0c06a1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">seems to be same as on t430, why duplicate it ?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/t431s/smihandler.c">File src/mainboard/lenovo/t430s/variants/t431s/smihandler.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/t431s/smihandler.c@25">Patch Set #8, Line 25:</a> <code style="font-family:monospace,monospace"> /* Enable 0x1600/0x1600 register pair */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">the whole file should be removed.<br>The bit can be set by ec/lenovo/h8/h8.c using devicetree values.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30021">change 30021</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30021"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic8062cacf5e8232405bb5757e1b1d063541f354a </div>
<div style="display:none"> Gerrit-Change-Number: 30021 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: Bill XIE <persmule@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Bill XIE <persmule@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 04 Dec 2018 08:56:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>